Remove recreational activities storyboard - #288
Merged
Conversation
Construct the existing SwiftUI hosts programmatically and route all activity-list and active-route entry points without Interface Builder. Manual tests required: - Open Experiences from the menu; open an activity, navigate back, and verify Edit/Done and deletion with VoiceOver. - Trigger an activity deep link while Home, the menu, and another screen are visible; verify it returns to Home and opens the refreshed Experiences list. - With route guidance active, open route details from both the beacon toolbar and route-guidance banner; verify back navigation. - End route guidance before opening details and verify the app safely remains on the current screen. Automated validation completed: - Soundscape Debug simulator build - UnitTests: 66 passed - InterfaceBuilderAudit --only candidates --kind all --format text
📝 WalkthroughWalkthroughRecreation and route-details navigation now instantiate SwiftUI hosting controllers directly. Storyboard scenes and segues for recreation are removed, while active-route lookup and explicit hosting-controller initializers handle route-details presentation. ChangesProgrammatic hosting navigation
Sequence Diagram(s)sequenceDiagram
participant HomeViewController
participant AuthoredActivitiesListHostingController
participant AuthoredActivitiesList
HomeViewController->>AuthoredActivitiesListHostingController: show recreation activities
AuthoredActivitiesListHostingController->>AuthoredActivitiesList: inject navigation helper and storage
sequenceDiagram
participant BeaconToolbarView
participant RouteDetailsViewHostingController
participant RouteDetailsView
BeaconToolbarView->>RouteDetailsViewHostingController: makeForActiveRoute()
RouteDetailsViewHostingController->>RouteDetailsView: initialize with active RouteGuidance
RouteDetailsViewHostingController-->>BeaconToolbarView: return view controller
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RDMurray
marked this pull request as ready for review
July 21, 2026 23:41
RDMurray
force-pushed
the
codex/remove-recreational-activities-storyboard
branch
from
July 26, 2026 21:27
80e068e to
cb3610a
Compare
RDMurray
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
These screens already use SwiftUI hosts. Constructing them directly removes legacy storyboard wrappers and makes their navigation paths explicit.
Validation
git diff --checkpassedManual testing required
Summary by CodeRabbit
New Features
Refactor
Documentation